[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 03 Apr 2017 23:28:22 -0700
From: Stephen Boyd <stephen.boyd@...aro.org>
To: Will Deacon <will.deacon@....com>
Cc: James Morse <james.morse@....com>,
Catalin Marinas <catalin.marinas@....com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Laura Abbott <labbott@...hat.com>,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2] arm64: print a fault message when attempting to write RO
memory
Quoting Will Deacon (2017-03-23 07:22:39)
> On Fri, Feb 24, 2017 at 05:39:08PM -0800, Stephen Boyd wrote:
> > Quoting James Morse (2017-02-20 03:10:10)
> > >
> > > You're right the user-address side of things will get caught in do_page_fault().
> > > I was trying to badly-explain 'is_permission_fault(esr)' isn't as general
> > > purpose as its name and prototype suggest, it only gives the results that the
> > > PAN checks expect when called with a user address.
> >
> > Ok. I'd rather not change the function in this patch because I'm only
> > moving the code around to use it higher up in the file. But if you
> > prefer I can combine the code movement with the addition of a new 'addr'
> > argument to this function and rework things based on that.
>
> Are you planning to send a v3 of this?
>
Sorry for the late reply. I was hoping that James would indicate
preference one way or the other. I suppose no reply means "yes" here, so
I'll go ahead and fold everything together into one patch and resend.
Powered by blists - more mailing lists