lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 4 Apr 2017 16:23:41 +0300
From:   Andy Shevchenko <>
To:     Sathyanarayanan Kuppuswamy Natarajan <>
Cc:     Kuppuswamy Sathyanarayanan 
        Andy Shevchenko <>,
        Zha Qipeng <>,
        "" <>,
        Guenter Roeck <>,
        Wim Van Sebroeck <>,
        David Box <>,
        Rajneesh Bhardwaj <>,
        Platform Driver <>,
        "" <>,
Subject: Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr
 read/write/update api's

On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan
<> wrote:

>>> +static inline int is_gcr_valid(u32 offset)
>> Pointer to ipcdev should be a parameter to this function.
> But ipcdev is a static variable, visible across this file. So there is
> no point in passing it as parameter.

That's one of refactoring needed for this library. You need to pass a
pointer to all internal functions and where it's possible to avoid
reference to a global variable.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists