linux-kernel - Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAFPZYHNwmsaJ_4q1S-EaathwtEp=5fCS9Huu6qoZb3Hg@mail.gmail.com>
Date:   Wed, 5 Apr 2017 13:02:59 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Daniel Baluta <daniel.baluta@....com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        shengjiu.wang@....com, patches@...nsource.wolfsonmicro.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>,
        viorel.suman@....com, mihai.serban@....com,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out
 freq search

On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta <daniel.baluta@....com> wrote:
> Add a separate function for deriving (sysclk, lrclk, bclk)
> when the clock is auto or pll.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>

Just noticed this warnings:

sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used
uninitialized in this function [-Wmaybe-uninitialized]
   wm8960_set_pll(codec, freq_in, best_freq_out);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:703:21: note: 'best_freq_out' was declared here
  int diff, closest, best_freq_out;
                     ^~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:806:46: warning: 'j' may be used
uninitialized in this function [-Wmaybe-uninitialized]
  snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6);
                                            ~~^~~~
sound/soc/codecs/wm8960.c:802:44: warning: 'i' may be used
uninitialized in this function [-Wmaybe-uninitialized]
  snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1);


There is no way I can end up with these variable uninitialized. Will
look more close and resend.

Thanks Charles for review.