linux-kernel - RE: [PATCH] qed: fix missing break in OOO_LB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR07MB230656675B9070E4E3C53A108D0A0@BL2PR07MB2306.namprd07.prod.outlook.com>
Date:   Wed, 5 Apr 2017 12:42:18 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Colin King <colin.king@...onical.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] qed: fix missing break in OOO_LB_TC case

> There seems to be a missing break on the OOO_LB_TC case, pq_id is being
> assigned and then re-assigned on the fall through default case and that
> seems suspect.
> 
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
> 
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks!

Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com>