linux-kernel - Re: [PATCH] qed: fix missing break in OOO_LB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170406.132457.208185850211874734.davem@davemloft.net>
Date:   Thu, 06 Apr 2017 13:24:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     Yuval.Mintz@...ium.com, Ariel.Elior@...ium.com,
        everest-linux-l2@...ium.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: fix missing break in OOO_LB_TC case

From: Colin King <colin.king@...onical.com>
Date: Wed,  5 Apr 2017 13:35:44 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> There seems to be a missing break on the OOO_LB_TC case, pq_id
> is being assigned and then re-assigned on the fall through default
> case and that seems suspect.
> 
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
> 
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.