linux-kernel - Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170407134007.GA22263@lunn.ch>
Date:   Fri, 7 Apr 2017 15:40:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Juergen Borleis <jbe@...gutronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, kernel@...gutronix.de,
        vivien.didelot@...oirfairelinux.com, davem@...emloft.net
Subject: Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support

Hi Juergen

> +Optional properties:
> +
> +- reset-gpios: GPIO to be used to reset the whole device, always low active

I would avoid the always low active comment. The input to the switch
is active low. But i've seen designs with an inverter in the reset
path, so from the perspective of the GPIO it would be active high. The
device tree binding allows for this, via the flags. And since you use
the gpiod API, it should all just work.

> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 { /* RMII fixed link to master */
> +				reg = <0>;
> +				label = "cpu";
> +				ethernet = <&master>;
> +			};
> +
> +			port@1 { /* external port 1 */
> +				compatible = "ethernet-phy-ieee802.3-c22";
> +				reg = <1>;
> +				label = "lan1;
> +			};

These are not PHY nodes, so does this compatible string do anything?

      Andrew