linux-kernel - Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170407141925.GB23415@lunn.ch>
Date:   Fri, 7 Apr 2017 16:19:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Juergen Borleis <jbe@...gutronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, kernel@...gutronix.de,
        vivien.didelot@...oirfairelinux.com, davem@...emloft.net
Subject: Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

> +static const struct of_device_id lan9303_mdio_of_match[] = {
> +	{ .compatible = "smsc,lan9303" },
> +	{ /* sentinel */ },
> +};

We still have the open question of is it a problem to have two
different drivers using the same compatible string. Changing these
strings is hard, once they are in use, so i would prefer to get this
answered before the code is accepted.

	 Andrew