linux-kernel - Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1e78674-64d1-0e51-3ca4-48d8500a3528@cogentembedded.com>
Date:   Fri, 7 Apr 2017 19:48:16 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Niklas Cassel <niklas.cassel@...s.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Niklas Cassel <niklass@...s.com>,
        Giuseppe CAVALLARO <peppe.cavallaro@...com>,
        Thierry Reding <treding@...dia.com>,
        Eric Engestrom <eric@...estrom.ch>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about
 LPI interrupt

Hello!

On 04/07/2017 05:30 PM, Niklas Cassel wrote:

> From: Niklas Cassel <niklas.cassel@...s.com>
>
> The hardware has a LPI interrupt.
> There is already code in the stmmac driver to parse and handle the
> interrupt. However, this information was missing from the DT binding.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
> ---
>  Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
> index f652b0c384ce..8977abc266ac 100644
> --- a/Documentation/devicetree/bindings/net/stmmac.txt
> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> @@ -8,8 +8,8 @@ Required properties:
>    that services interrupts for this device
>  - interrupts: Should contain the STMMAC interrupts
>  - interrupt-names: Should contain the interrupt names "macirq"
> -  "eth_wake_irq" if this interrupt is supported in the "interrupts"
> -  property
> +  "eth_wake_irq" if this interrupt is supported in the "interrupts property

    Missed closing quote?

> +  "eth_lpi" if this interrupt is supported in the "interrupts" property
>  - phy-mode: See ethernet.txt file in the same directory.
>  - snps,reset-gpio 	gpio number for phy reset.
>  - snps,reset-active-low boolean flag to indicate if phy reset is active low.
[...]

MBR, Sergei