linux-kernel - Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 8 Apr 2017 12:50:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Prasant Jalan <prasant.jalan@...il.com>
Cc:     forest@...ttletooquiet.net, arushisinghal19971997@...il.com,
        devel@...verdev.osuosl.org, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org, michael.schacht.hansen@...il.com
Subject: Re: [PATCH v2] staging: vt6656: fixed an indentation coding style
 issue

On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote:
> 
> Replacing spaces with tabs for indetation to fix checkpatch.pl error
> "code indent should use tabs where possible".
> 
> 
> Signed-off-by: Prasant Jalan <prasant.jalan@...il.com>
> ---
> 
>   v2:
>     - improved changelog comments
>     - fixed only one issue
> 
> 
>  drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
>  1 file changed, 19 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index 1835cd1..7ebd1ee 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
>  }
>  
>  static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
> -	                    u32 frame_length, u16 rate, int need_ack)
> +				u32 frame_length, u16 rate, int need_ack)

No, it should look like:

			      u32 frame_length, u16 rate, int need_ack)

Please fix them up that way.

thanks,

greg k-h