linux-kernel - Re: [PATCH] power: supply: lp8788: prevent out of bounds array access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABNMmsBFUoY99JOB-qPR7Dbxn6tOU5ZRcnQc8LqctEW3P=HwUw@mail.gmail.com>
Date:   Sat, 8 Apr 2017 13:55:24 +0300
From:   Giedrius Statkevičius 
        <giedrius.statkevicius@...il.com>
To:     "Kim, Milo" <milo.kim@...com>
Cc:     sre@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: supply: lp8788: prevent out of bounds array access

Ping.

On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo <milo.kim@...com> wrote:
> On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote:
>>
>> val might become 7 in which case stime[7] (array of length 7) would be
>> accessed during the scnprintf call later and that will cause issues.
>> Obviously, string concatenation is not intended here so just a comma needs
>> to be added to fix the issue.
>>
>> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@...il.com>
>
>
> Acked-by: Milo Kim <milo.kim@...com>
>
>
>> ---
>>  drivers/power/supply/lp8788-charger.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/lp8788-charger.c
>> b/drivers/power/supply/lp8788-charger.c
>> index 509e2b341bd6..677f7c40b25a 100644
>> --- a/drivers/power/supply/lp8788-charger.c
>> +++ b/drivers/power/supply/lp8788-charger.c
>> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device
>> *dev,
>>  {
>>         struct lp8788_charger *pchg = dev_get_drvdata(dev);
>>         char *stime[] = { "400ms", "5min", "10min", "15min",
>> -                       "20min", "25min", "30min" "No timeout" };
>> +                       "20min", "25min", "30min", "No timeout" };
>>         u8 val;
>>
>>         lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
>>
>