linux-kernel - Re: [PATCH v3] ia64: fix module loading for gcc-5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79cc2afd-1655-c276-a53f-2e2202a7e0ee@users.sourceforge.net>
Date:   Sun, 9 Apr 2017 10:27:52 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Sergei Trofimovich <slyfox@...too.org>
Cc:     linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        "H . J . Lu" <hjl.tools@...il.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v3] ia64: fix module loading for gcc-5.4

> Starting from gcc-5.4+ gcc generates MLX

How do you think about to omit the plus character?


> instructions in more cases to refer local
> symbols:

I wonder about your choice of a line length limit here.


> That caused ia64 module loader to choke
> on such instructions:
>     fuse: invalid slot number 1 for IMM64

Why does it matter to check such a value?


> … That limitation was fixed in linux by

Would it be nicer to write “in corresponding source code by the”?


> Change since v2: checkpatched, fixed typos by found by Markus Elfring

Does this version information contain an unwanted word repetition?
How does it fit to the identifier “v3” in the commit subject?

Regards,
Markus