linux-kernel - Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a2ab310-adc7-ad66-4094-13e2125734f2@st.com>
Date:   Tue, 11 Apr 2017 08:08:35 +0200
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Niklas Cassel <niklas.cassel@...s.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Niklas Cassel <niklass@...s.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Thierry Reding <treding@...dia.com>,
        Eric Engestrom <eric@...estrom.ch>
CC:     <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about
 LPI interrupt

Hi Niklas

On 4/10/2017 9:43 AM, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>
>
> The hardware has a LPI interrupt.
> There is already code in the stmmac driver to parse and handle the
> interrupt. However, this information was missing from the DT binding.

i wonder if we could improve the comments in this patch too
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
> ---
>   Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
> index f652b0c384ce..84e4cbfd3b0f 100644
> --- a/Documentation/devicetree/bindings/net/stmmac.txt
> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> @@ -8,8 +8,8 @@ Required properties:
>     that services interrupts for this device
>   - interrupts: Should contain the STMMAC interrupts
>   - interrupt-names: Should contain the interrupt names "macirq"
> -  "eth_wake_irq" if this interrupt is supported in the "interrupts"
> -  property
> +  "eth_wake_irq" if this interrupt is supported in the "interrupts" property
this is the PMT interrupt to manage the remote wake-up packet detection
> +  "eth_lpi" if this interrupt is supported in the "interrupts" property
This is the interrupt that occurs when Tx or Rx enter/exit from LPI state

Regards
Peppe
>   - phy-mode: See ethernet.txt file in the same directory.
>   - snps,reset-gpio 	gpio number for phy reset.
>   - snps,reset-active-low boolean flag to indicate if phy reset is active low.
> @@ -152,8 +152,8 @@ Examples:
>   		compatible = "st,spear600-gmac";
>   		reg = <0xe0800000 0x8000>;
>   		interrupt-parent = <&vic1>;
> -		interrupts = <24 23>;
> -		interrupt-names = "macirq", "eth_wake_irq";
> +		interrupts = <24 23 22>;
> +		interrupt-names = "macirq", "eth_wake_irq", "eth_lpi";
>   		mac-address = [000000000000]; /* Filled in by U-Boot */
>   		max-frame-size = <3800>;
>   		phy-mode = "gmii";