linux-kernel - Re: [PATCH] thermal: cpu_cooling: Use kmalloc_array() in __cpufreq_cooling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170411061027.GB3670@vireshk-i7>
Date:   Tue, 11 Apr 2017 11:40:27 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-pm@...r.kernel.org,
        Amit Daniel Kachhap <amit.kachhap@...il.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Javi Merino <javi.merino@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] thermal: cpu_cooling: Use kmalloc_array() in
 __cpufreq_cooling_register()

On 10-04-17, 17:12, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 10 Apr 2017 17:00:13 +0200
> 
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/thermal/cpu_cooling.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 69d0f430b2d1..273d9d5dbe0f 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -823,8 +823,9 @@ __cpufreq_cooling_register(struct device_node *np,
>  	cpufreq_for_each_valid_entry(pos, table)
>  		cpufreq_dev->max_level++;
>  
> -	cpufreq_dev->freq_table = kmalloc(sizeof(*cpufreq_dev->freq_table) *
> -					  cpufreq_dev->max_level, GFP_KERNEL);
> +	cpufreq_dev->freq_table = kmalloc_array(cpufreq_dev->max_level,
> +						sizeof(*cpufreq_dev->freq_table),
> +						GFP_KERNEL);
>  	if (!cpufreq_dev->freq_table) {
>  		cool_dev = ERR_PTR(-ENOMEM);
>  		goto free_time_in_idle_timestamp;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh