linux-kernel - Re: [PATCH] power: supply: charger manager: refactor return statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170411142829.ymplbmjbqswqxin5@earth>
Date:   Tue, 11 Apr 2017 16:28:29 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Andi Shyti <andi.shyti@...il.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Jiri Kosina <trivial@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>,
        Andi Shyti <andi.shyti@...sung.com>
Subject: Re: [PATCH] power: supply: charger manager: refactor return
 statements

Hi,

On Thu, Mar 30, 2017 at 12:13:57AM +0900, Andi Shyti wrote:
> Some trivial improvements on the returning value of the
> functions:
> 
>  - remove unnecessary goto labels that just return, return
>    immediately, instead.
> 
>  - do not initialize when not needed.
> 
>  - return the value from the calling function that fails instead
>    of politically choosing -EINVAL.
> 
> Signed-off-by: Andi Shyti <andi@...zian.org>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)