linux-kernel - Re: [PATCH 1/2] firmware: Google VPD: import lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1491934554.17839.13.camel@perches.com>
Date:   Tue, 11 Apr 2017 11:15:54 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thierry Escande <thierry.escande@...labora.com>
Cc:     linux-kernel@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>,
        cocci <cocci@...teme.lip6.fr>
Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files

On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote:
> Care to use "real" kernel variable types please?  u8, u16, and others
> are you friend, uint8_t really isn't what we prefer, and checkpatch
> should tell you that...

checkpatch doesn't warn about "u?int\d+_t" types unless
--strict is enabled and most likely it shouldn't.

There are about 100k uses of those types in the kernel.

Many are uapi and are perhaps properly used in drivers and lib.

checkpatch can't tell what type a particular use should have.

Maybe coccinelle could based on whether the include comes
from a uapi directory or prototype or some such.