linux-kernel - Re: [PATCH 0/7] perf tool: pipe-mode fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411181719.GC3275@kernel.org>
Date:   Tue, 11 Apr 2017 15:17:19 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     David Carrillo-Cisneros <davidcc@...gle.com>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH 0/7] perf tool: pipe-mode fixes

Em Tue, Apr 11, 2017 at 11:49:06AM +0200, Jiri Olsa escreveu:
> On Mon, Apr 10, 2017 at 01:14:25PM -0700, David Carrillo-Cisneros wrote:
> > Various fixes for perf tool pipe-mode for bugs that arose while trying
> > to make this work:
> > 
> >     perf record -o - noploop | perf inject -b | perf annotate -i -
> > 
> > David Carrillo-Cisneros (7):
> >   perf inject: don't proceed if perf_session__process_event fails
> >   perf inject: copy events when reordering events in pipe mode
> >   perf tool: describe pipe mode in perf.data-file-fomat.txt
> >   perf annotate: process attr and build_id records
> >   perf session: don't rely on evlist in pipe mode
> >   perf tool: protect empty evlists
> >   perf tool: do not print missing features in pipe-mode
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Applied all, except 6/7, will audit all users of those first() and
last() methods to check if this is ok or what changes are needed to
robustify code assuming they always return an evsel (which is false, and
this patch fixes, as the evlist may be empty).

- Arnaldo.