linux-kernel - Re: [patch 06/13] sparc/sysfs: Replace racy task affinity logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170412.215206.1568460664651298892.davem@davemloft.net>
Date:   Wed, 12 Apr 2017 21:52:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...nel.org, bigeasy@...utronix.de, benh@...nel.crashing.org,
        fenghua.yu@...el.com, herbert@...dor.apana.org.au,
        jiangshanlai@...il.com, lenb@...nel.org, mpe@...erman.id.au,
        rjw@...ysocki.net, tj@...nel.org, tony.luck@...el.com,
        viresh.kumar@...aro.org, sparclinux@...r.kernel.org
Subject: Re: [patch 06/13] sparc/sysfs: Replace racy task affinity logic

From: Thomas Gleixner <tglx@...utronix.de>
Date: Wed, 12 Apr 2017 22:07:32 +0200

> @@ -142,7 +122,8 @@ static unsigned long write_mmustat_enabl
>  static ssize_t show_mmustat_enable(struct device *s,
>  				struct device_attribute *attr, char *buf)
>  {
> -	unsigned long val = run_on_cpu(s->id, read_mmustat_enable, 0);
> +	long val = work_on_cpu(s->id, read_mmustat_enable, 0);

Last argument to work_on_cpu() should be NULL since it's a pointer
I guess.

But otherwise I have no problems with this:

Acked-by: David S. Miller <davem@...emloft.net>