lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201704130951.iFcdmgZy%fengguang.wu@intel.com>
Date:   Thu, 13 Apr 2017 09:59:12 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paolo Valente <paolo.valente@...aro.org>
Cc:     kbuild-all@...org, Jens Axboe <axboe@...nel.dk>,
        Tejun Heo <tj@...nel.org>,
        Fabio Checconi <fchecconi@...il.com>,
        Arianna Avanzini <avanzini.arianna@...il.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        ulf.hansson@...aro.org, linus.walleij@...aro.org,
        broonie@...nel.org, Paolo Valente <paolo.valente@...aro.org>
Subject: Re: [PATCH V3 02/16] block, bfq: add full hierarchical scheduling
 and cgroups support

Hi Arianna,

[auto build test ERROR on block/for-next]
[also build test ERROR on v4.11-rc6 next-20170412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paolo-Valente/Introduce-the-BFQ-I-O-scheduler/20170412-021320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m32r 

Note: the linux-review/Paolo-Valente/Introduce-the-BFQ-I-O-scheduler/20170412-021320 HEAD 36eb6533f8b6705991185201f75e98880cd223f7 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4559:13: error: invalid storage class for function 'bfq_bfqq_may_idle'
    static bool bfq_bfqq_may_idle(struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4602:13: error: invalid storage class for function 'bfq_bfqq_must_idle'
    static bool bfq_bfqq_must_idle(struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4614:26: error: invalid storage class for function 'bfq_select_queue'
    static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd)
                             ^~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4714:24: error: invalid storage class for function 'bfq_dispatch_rq_from_bfqq'
    static struct request *bfq_dispatch_rq_from_bfqq(struct bfq_data *bfqd,
                           ^~~~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4746:13: error: invalid storage class for function 'bfq_has_work'
    static bool bfq_has_work(struct blk_mq_hw_ctx *hctx)
                ^~~~~~~~~~~~
   block/bfq-iosched.c:4758:24: error: invalid storage class for function '__bfq_dispatch_request'
    static struct request *__bfq_dispatch_request(struct blk_mq_hw_ctx *hctx)
                           ^~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4843:24: error: invalid storage class for function 'bfq_dispatch_request'
    static struct request *bfq_dispatch_request(struct blk_mq_hw_ctx *hctx)
                           ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4862:13: error: invalid storage class for function 'bfq_put_queue'
    static void bfq_put_queue(struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:4884:13: error: invalid storage class for function 'bfq_exit_bfqq'
    static void bfq_exit_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:4896:13: error: invalid storage class for function 'bfq_exit_icq_bfqq'
    static void bfq_exit_icq_bfqq(struct bfq_io_cq *bic, bool is_sync)
                ^~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4914:13: error: invalid storage class for function 'bfq_exit_icq'
    static void bfq_exit_icq(struct io_cq *icq)
                ^~~~~~~~~~~~
   block/bfq-iosched.c:4927:1: error: invalid storage class for function 'bfq_set_next_ioprio_data'
    bfq_set_next_ioprio_data(struct bfq_queue *bfqq, struct bfq_io_cq *bic)
    ^~~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4973:13: error: invalid storage class for function 'bfq_check_ioprio_change'
    static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
                ^~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5001:13: error: invalid storage class for function 'bfq_init_bfqq'
    static void bfq_init_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq,
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:5036:27: error: invalid storage class for function 'bfq_async_queue_prio'
    static struct bfq_queue **bfq_async_queue_prio(struct bfq_data *bfqd,
                              ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5055:26: error: invalid storage class for function 'bfq_get_queue'
    static struct bfq_queue *bfq_get_queue(struct bfq_data *bfqd,
                             ^~~~~~~~~~~~~
   block/bfq-iosched.c:5120:13: error: invalid storage class for function 'bfq_update_io_thinktime'
    static void bfq_update_io_thinktime(struct bfq_data *bfqd,
                ^~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5135:1: error: invalid storage class for function 'bfq_update_io_seektime'
    bfq_update_io_seektime(struct bfq_data *bfqd, struct bfq_queue *bfqq,
    ^~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5157:13: error: invalid storage class for function 'bfq_update_idle_window'
    static void bfq_update_idle_window(struct bfq_data *bfqd,
                ^~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5192:13: error: invalid storage class for function 'bfq_rq_enqueued'
    static void bfq_rq_enqueued(struct bfq_data *bfqd, struct bfq_queue *bfqq,
                ^~~~~~~~~~~~~~~
   block/bfq-iosched.c:5258:13: error: invalid storage class for function '__bfq_insert_request'
    static void __bfq_insert_request(struct bfq_data *bfqd, struct request *rq)
                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5270:13: error: invalid storage class for function 'bfq_insert_request'
    static void bfq_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq,
                ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5305:13: error: invalid storage class for function 'bfq_insert_requests'
    static void bfq_insert_requests(struct blk_mq_hw_ctx *hctx,
                ^~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5317:13: error: invalid storage class for function 'bfq_update_hw_tag'
    static void bfq_update_hw_tag(struct bfq_data *bfqd)
                ^~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5342:13: error: invalid storage class for function 'bfq_completed_request'
    static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd)
                ^~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5373:13: error: invalid storage class for function 'bfq_put_rq_priv_body'
    static void bfq_put_rq_priv_body(struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5380:13: error: invalid storage class for function 'bfq_put_rq_private'
    static void bfq_put_rq_private(struct request_queue *q, struct request *rq)
                ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5425:12: error: invalid storage class for function 'bfq_get_rq_private'
    static int bfq_get_rq_private(struct request_queue *q, struct request *rq,
               ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5468:13: error: invalid storage class for function 'bfq_idle_slice_timer_body'
    static void bfq_idle_slice_timer_body(struct bfq_queue *bfqq)
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5511:29: error: invalid storage class for function 'bfq_idle_slice_timer'
    static enum hrtimer_restart bfq_idle_slice_timer(struct hrtimer *timer)
                                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5531:13: error: invalid storage class for function '__bfq_put_async_bfqq'
    static void __bfq_put_async_bfqq(struct bfq_data *bfqd,
                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5553:13: error: invalid storage class for function 'bfq_put_async_queues'
    static void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg)
                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5564:13: error: invalid storage class for function 'bfq_exit_queue'
    static void bfq_exit_queue(struct elevator_queue *e)
                ^~~~~~~~~~~~~~
>> block/bfq-iosched.c:5590:13: error: invalid storage class for function 'bfq_init_root_group'
    static void bfq_init_root_group(struct bfq_group *root_group,
                ^~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:5605:12: error: invalid storage class for function 'bfq_init_queue'
    static int bfq_init_queue(struct request_queue *q, struct elevator_type *e)
               ^~~~~~~~~~~~~~
   block/bfq-iosched.c:5699:13: error: invalid storage class for function 'bfq_slab_kill'
    static void bfq_slab_kill(void)
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:5704:19: error: invalid storage class for function 'bfq_slab_setup'
    static int __init bfq_slab_setup(void)
                      ^~~~~~~~~~~~~~
   block/bfq-iosched.c:5712:16: error: invalid storage class for function 'bfq_var_show'
    static ssize_t bfq_var_show(unsigned int var, char *page)
                   ^~~~~~~~~~~~
   block/bfq-iosched.c:5717:16: error: invalid storage class for function 'bfq_var_store'
    static ssize_t bfq_var_store(unsigned long *var, const char *page,
                   ^~~~~~~~~~~~~
   block/bfq-iosched.c:5740:15: error: invalid storage class for function 'bfq_fifo_expire_sync_show'
    SHOW_FUNCTION(bfq_fifo_expire_sync_show, bfqd->bfq_fifo_expire[1], 2);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5741:15: error: invalid storage class for function 'bfq_fifo_expire_async_show'
    SHOW_FUNCTION(bfq_fifo_expire_async_show, bfqd->bfq_fifo_expire[0], 2);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5741:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_fifo_expire_async_show, bfqd->bfq_fifo_expire[0], 2);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5742:15: error: invalid storage class for function 'bfq_back_seek_max_show'
    SHOW_FUNCTION(bfq_back_seek_max_show, bfqd->bfq_back_max, 0);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5742:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_back_seek_max_show, bfqd->bfq_back_max, 0);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5743:15: error: invalid storage class for function 'bfq_back_seek_penalty_show'
    SHOW_FUNCTION(bfq_back_seek_penalty_show, bfqd->bfq_back_penalty, 0);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5743:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_back_seek_penalty_show, bfqd->bfq_back_penalty, 0);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5744:15: error: invalid storage class for function 'bfq_slice_idle_show'
    SHOW_FUNCTION(bfq_slice_idle_show, bfqd->bfq_slice_idle, 2);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5744:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_slice_idle_show, bfqd->bfq_slice_idle, 2);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5745:15: error: invalid storage class for function 'bfq_max_budget_show'
    SHOW_FUNCTION(bfq_max_budget_show, bfqd->bfq_user_max_budget, 0);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5745:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_max_budget_show, bfqd->bfq_user_max_budget, 0);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5746:15: error: invalid storage class for function 'bfq_timeout_sync_show'
    SHOW_FUNCTION(bfq_timeout_sync_show, bfqd->bfq_timeout, 1);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
                   ^~~~~~
   block/bfq-iosched.c:5730:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
    ^
   block/bfq-iosched.c:5746:1: note: in expansion of macro 'SHOW_FUNCTION'
    SHOW_FUNCTION(bfq_timeout_sync_show, bfqd->bfq_timeout, 1);
    ^~~~~~~~~~~~~
   block/bfq-iosched.c:5747:15: error: invalid storage class for function 'bfq_strict_guarantees_show'
    SHOW_FUNCTION(bfq_strict_guarantees_show, bfqd->strict_guarantees, 0);
                  ^
   block/bfq-iosched.c:5730:16: note: in definition of macro 'SHOW_FUNCTION'
    static ssize_t __FUNC(struct elevator_queue *e, char *page)  \
--
   block/bfq-iosched.c:5966:20: error: invalid storage class for function 'bfq_exit'
    static void __exit bfq_exit(void)
                       ^~~~~~~~
   In file included from include/linux/printk.h:5:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from block/bfq-iosched.c:90:
   block/bfq-iosched.c:5975:13: error: initializer element is not constant
    module_init(bfq_init);
                ^
   include/linux/init.h:164:58: note: in definition of macro '__define_initcall'
     __attribute__((__section__(".initcall" #id ".init"))) = fn;
                                                             ^~
   include/linux/init.h:198:24: note: in expansion of macro 'device_initcall'
    #define __initcall(fn) device_initcall(fn)
                           ^~~~~~~~~~~~~~~
   include/linux/module.h:85:24: note: in expansion of macro '__initcall'
    #define module_init(x) __initcall(x);
                           ^~~~~~~~~~
   block/bfq-iosched.c:5975:1: note: in expansion of macro 'module_init'
    module_init(bfq_init);
    ^~~~~~~~~~~
   block/bfq-iosched.c:5976:13: error: initializer element is not constant
    module_exit(bfq_exit);
                ^
   include/linux/init.h:201:50: note: in definition of macro '__exitcall'
     static exitcall_t __exitcall_##fn __exit_call = fn
                                                     ^~
   block/bfq-iosched.c:5976:1: note: in expansion of macro 'module_exit'
    module_exit(bfq_exit);
    ^~~~~~~~~~~
   include/linux/init.h:201:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     static exitcall_t __exitcall_##fn __exit_call = fn
     ^
   include/linux/module.h:97:24: note: in expansion of macro '__exitcall'
    #define module_exit(x) __exitcall(x);
                           ^~~~~~~~~~
   block/bfq-iosched.c:5976:1: note: in expansion of macro 'module_exit'
    module_exit(bfq_exit);
    ^~~~~~~~~~~
   In file included from include/linux/module.h:18:0,
                    from block/bfq-iosched.c:90:
   include/linux/moduleparam.h:27:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
      struct __UNIQUE_ID(name) {}
      ^
   include/linux/module.h:160:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:204:32: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
                                   ^~~~~~~~~~~
   block/bfq-iosched.c:5978:1: note: in expansion of macro 'MODULE_AUTHOR'
    MODULE_AUTHOR("Paolo Valente");
    ^~~~~~~~~~~~~
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from block/bfq-iosched.c:90:
   include/linux/compiler-gcc.h:184:45: error: expected declaration or statement at end of input
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:56:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:184:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:57:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:184:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:27:10: note: in expansion of macro '__UNIQUE_ID'
      struct __UNIQUE_ID(name) {}
             ^~~~~~~~~~~
   include/linux/module.h:160:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:207:42: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description)
                                             ^~~~~~~~~~~
   block/bfq-iosched.c:5980:1: note: in expansion of macro 'MODULE_DESCRIPTION'
    MODULE_DESCRIPTION("MQ Budget Fair Queueing I/O Scheduler");
    ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c: At top level:
   block/bfq-iosched.c:712:13: warning: 'bfq_check_ioprio_change' declared 'static' but never defined [-Wunused-function]
    static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio);
                ^~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:713:13: warning: 'bfq_put_queue' used but never defined
    static void bfq_put_queue(struct bfq_queue *bfqq);
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:714:26: warning: 'bfq_get_queue' used but never defined
    static struct bfq_queue *bfq_get_queue(struct bfq_data *bfqd,
                             ^~~~~~~~~~~~~
>> block/bfq-iosched.c:717:13: warning: 'bfq_put_async_queues' used but never defined
    static void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg);
                ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:718:13: warning: 'bfq_exit_bfqq' declared 'static' but never defined [-Wunused-function]
    static void bfq_exit_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq);
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:3632:13: warning: 'bfq_bfqq_expire' used but never defined
    static void bfq_bfqq_expire(struct bfq_data *bfqd,
                ^~~~~~~~~~~~~~~
   block/bfq-iosched.c:5553:13: warning: 'bfq_put_async_queues' defined but not used [-Wunused-function]
    static void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg)
                ^~~~~~~~~~~~~~~~~~~~

vim +/bfq_init_root_group +5590 block/bfq-iosched.c

  5525		if (bfqq)
  5526			bfq_idle_slice_timer_body(bfqq);
  5527	
  5528		return HRTIMER_NORESTART;
  5529	}
  5530	
> 5531	static void __bfq_put_async_bfqq(struct bfq_data *bfqd,
  5532					 struct bfq_queue **bfqq_ptr)
  5533	{
  5534		struct bfq_queue *bfqq = *bfqq_ptr;
  5535	
  5536		bfq_log(bfqd, "put_async_bfqq: %p", bfqq);
  5537		if (bfqq) {
  5538			bfq_bfqq_move(bfqd, bfqq, bfqd->root_group);
  5539	
  5540			bfq_log_bfqq(bfqd, bfqq, "put_async_bfqq: putting %p, %d",
  5541				     bfqq, bfqq->ref);
  5542			bfq_put_queue(bfqq);
  5543			*bfqq_ptr = NULL;
  5544		}
  5545	}
  5546	
  5547	/*
  5548	 * Release all the bfqg references to its async queues.  If we are
  5549	 * deallocating the group these queues may still contain requests, so
  5550	 * we reparent them to the root cgroup (i.e., the only one that will
  5551	 * exist for sure until all the requests on a device are gone).
  5552	 */
  5553	static void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg)
  5554	{
  5555		int i, j;
  5556	
  5557		for (i = 0; i < 2; i++)
  5558			for (j = 0; j < IOPRIO_BE_NR; j++)
  5559				__bfq_put_async_bfqq(bfqd, &bfqg->async_bfqq[i][j]);
  5560	
  5561		__bfq_put_async_bfqq(bfqd, &bfqg->async_idle_bfqq);
  5562	}
  5563	
  5564	static void bfq_exit_queue(struct elevator_queue *e)
  5565	{
  5566		struct bfq_data *bfqd = e->elevator_data;
  5567		struct bfq_queue *bfqq, *n;
  5568	
  5569		hrtimer_cancel(&bfqd->idle_slice_timer);
  5570	
  5571		spin_lock_irq(&bfqd->lock);
  5572		list_for_each_entry_safe(bfqq, n, &bfqd->idle_list, bfqq_list)
  5573			bfq_deactivate_bfqq(bfqd, bfqq, false, false);
  5574		spin_unlock_irq(&bfqd->lock);
  5575	
  5576		hrtimer_cancel(&bfqd->idle_slice_timer);
  5577	
  5578	#ifdef CONFIG_BFQ_GROUP_IOSCHED
  5579		blkcg_deactivate_policy(bfqd->queue, &blkcg_policy_bfq);
  5580	#else
  5581		spin_lock_irq(&bfqd->lock);
  5582		bfq_put_async_queues(bfqd, bfqd->root_group);
  5583		kfree(bfqd->root_group);
  5584		spin_unlock_irq(&bfqd->lock);
  5585	#endif
  5586	
  5587		kfree(bfqd);
  5588	}
  5589	
> 5590	static void bfq_init_root_group(struct bfq_group *root_group,
  5591					struct bfq_data *bfqd)
  5592	{
  5593		int i;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (41454 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ