linux-kernel - Re: [PATCH] usb: gadget: remove redundant self assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170417074244.GA15565@b29397-desktop>
Date:   Mon, 17 Apr 2017 15:42:44 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, peter.chen@....com,
        k.opasiak@...sung.com, yoshihiro.shimoda.uh@...esas.com,
        colin.king@...onical.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: remove redundant self assignment

On Sun, Apr 16, 2017 at 08:12:50PM -0700, Stefan Agner wrote:
> The assignment ret = ret is redundant and can be removed.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> A very similar patch has been applied already last year, but there is
> a second such assignment...
> 
> --
> Stefan
> 
>  drivers/usb/gadget/udc/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d685d82dcf48..b57bd53812fe 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
>  		goto out;
>  
>  	ret = ep->ops->disable(ep);
> -	if (ret) {
> -		ret = ret;
> +	if (ret)
>  		goto out;
> -	}
>  
>  	ep->enabled = false;
>  

Reviewed-by: Peter Chen <peter.chen@....com>

-- 

Best Regards,
Peter Chen