linux-kernel - Re: [PATCH] usb: gadget: remove redundant self assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <e231a9ac-4a9d-3571-ebd9-32cfc07c99fd@samsung.com>
Date:   Wed, 19 Apr 2017 11:01:00 +0200
From:   Krzysztof Opasiak <k.opasiak@...sung.com>
To:     Stefan Agner <stefan@...er.ch>, balbi@...nel.org
Cc:     gregkh@...uxfoundation.org, peter.chen@....com,
        yoshihiro.shimoda.uh@...esas.com, colin.king@...onical.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: remove redundant self assignment



On 04/17/2017 05:12 AM, Stefan Agner wrote:
> The assignment ret = ret is redundant and can be removed.
>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> A very similar patch has been applied already last year, but there is
> a second such assignment...
>
> --
> Stefan
>
>  drivers/usb/gadget/udc/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d685d82dcf48..b57bd53812fe 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
>  		goto out;
>
>  	ret = ep->ops->disable(ep);
> -	if (ret) {
> -		ret = ret;
> +	if (ret)
>  		goto out;
> -	}
>
>  	ep->enabled = false;
>
>

Reviewed-by: Krzysztof Opasiak <k.opasiak@...sung.com>

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics