linux-kernel - Re: [PATCH v3 1/1] perf tools: fix perf build with ARCH=x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58F48B70.1080602@mentor.com>
Date:   Mon, 17 Apr 2017 02:31:28 -0700
From:   Jiada Wang <jiada_wang@...tor.com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...nel.org>,
        <wangnan0@...wei.com>, <ravi.bangoria@...ux.vnet.ibm.com>,
        <mhiramat@...nel.org>, <linux-kernel@...r.kernel.org>,
        <erosca@...adit-jv.com>
Subject: Re: [PATCH v3 1/1] perf tools: fix perf build with ARCH=x86_64

On 04/10/2017 12:44 AM, Jiri Olsa wrote:
> On Sun, Apr 09, 2017 at 07:43:15PM -0700, Jiada Wang wrote:
>> Hello Jiri
>>
>> On 04/09/2017 10:27 AM, Jiri Olsa wrote:
>>> On Tue, Apr 04, 2017 at 11:25:44PM -0700, jiada_wang@...tor.com wrote:
>>>> From: Jiada Wang<jiada_wang@...tor.com>
>>>>
>>>> with commit: 0a943cb10ce78 (tools build: Add HOSTARCH Makefile variable)
>>>> the following build failure is seen when build with ARCH=x86_64
>>> is that described somewhere as a valid building interface?
>>> I never use it so I have no idea.. would you describe your
>>> build env/process?
>> I used "ARCH=x86_64 make -C tools perf V=1" to build perf for x86_64 ARCH.
> you're on x86 machine right? I don't see CROSS_COMPILE being used..
>
> what's the purpose of the ARCH var setup then?
Sorry for late response.

Yes, I am on x86 machine, and want to build for x86_64,
I didn't mention CROSS_COMPILE option in my last reply is because no
matter what 'CROSS_COMPILE' is, the issue can be reproduced when 
ARCH=X86_64.

The full command I used to build perf, is somewhat near to
make -C tools perf V=2 ARCH=x86_64 CROSS_COMPILE=i686-pc-linux-gnc-g 
CC=i686-pc-linux-gnc-gcc

Thanks,
Jiada

>
>>>> In file included from util/event.c:2:0:
>>>>       tools/include/uapi/linux/mman.h:4:27: fatal error: uapi/asm/mman.h: No such file or directory
>>>>       compilation terminated.
>>>>
>>>> fix this issue by use SRCARCH instead of ARCH in perf.
>>> please describe also the the issue itself in the changelog, not just the fix
>> I will update changelog with detail information about the issue in v4
>>>
>>> so objtool is using SRCARCH this way, I guess it's fine
>>>
>>> if we go this way, you also need to change the pmu-events/Build
>>> and there's some comment using $(ARCH) in util/header.c
>> will update pmu-events/Build in v4
> I'll check
>
> thanks,
> jirka