linux-kernel - Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1005a5c3-22d1-b082-0383-d8f74e711315@caviumnetworks.com>
Date:   Tue, 18 Apr 2017 08:16:58 -0700
From:   David Daney <ddaney@...iumnetworks.com>
To:     Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, frowand.list@...il.com,
        david.daney@...ium.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: fix "/cpus" reference leak in
 of_numa_parse_cpu_nodes()

On 04/17/2017 05:29 PM, Tyrel Datwyler wrote:
> The call to of_find_node_by_path("/cpus") returns the cpus device_node
> with its reference count incremented. There is no matching of_node_put()
> call in of_numa_parse_cpu_nodes() which results in a leaked reference
> to the "/cpus" node.
> 
> This patch adds an of_node_put() to release the reference.

Good catch:
Acked-by: David Daney <david.daney@...ium.com>

> 
> fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
> Signed-off-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
> ---
>   drivers/of/of_numa.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
> index a53982a..2db1f7a 100644
> --- a/drivers/of/of_numa.c
> +++ b/drivers/of/of_numa.c
> @@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void)
>   		else
>   			node_set(nid, numa_nodes_parsed);
>   	}
> +
> +	of_node_put(cpus);
>   }
>   
>   static int __init of_numa_parse_memory_nodes(void)
>