linux-kernel - Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+_SO-Uzkp5MoCQkF0BWVuU4TFZEFb0tU8TjXE09PC4Ew@mail.gmail.com>
Date:   Tue, 18 Apr 2017 11:08:53 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     David Daney <ddaney@...iumnetworks.com>,
        Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Frank Rowand <frowand.list@...il.com>,
        David Daney <david.daney@...ium.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

On Tue, Apr 18, 2017 at 10:16 AM, David Daney <ddaney@...iumnetworks.com> wrote:
> On 04/17/2017 05:29 PM, Tyrel Datwyler wrote:
>>
>> The call to of_find_node_by_path("/cpus") returns the cpus device_node
>> with its reference count incremented. There is no matching of_node_put()
>> call in of_numa_parse_cpu_nodes() which results in a leaked reference
>> to the "/cpus" node.
>>
>> This patch adds an of_node_put() to release the reference.
>
>
> Good catch:
> Acked-by: David Daney <david.daney@...ium.com>

Applied, thanks.

Rob