linux-kernel - Re: [PATCH] perf, tools: Fix display of data source snoop indication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170419185001.GJ4021@tassilo.jf.intel.com>
Date:   Wed, 19 Apr 2017 11:50:01 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, eranian@...gle.com
Subject: Re: [PATCH] perf, tools: Fix display of data source snoop indication

On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > perf mem report doesn't display the data source snoop indication correctly.
> > 
> > In the kernel API the definition is
> 
> missing something?

#define PERF_MEM_SNOOP_NONE     0x02 /* no snoop */
#define PERF_MEM_SNOOP_HIT      0x04 /* snoop hit */
#define PERF_MEM_SNOOP_MISS     0x08 /* snoop miss */

>  
> > but the table used by the perf tools exchanged Hit and Miss
> > 
> >         "None",
> >         "Miss",
> >         "Hit",
> > 
> > Fix the table in perf.
> > 
> > Cc: eranian@...gle.com
> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> > ---
> >  tools/perf/util/mem-events.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> > index 1d4ab53c60ca..865ba3c39284 100644
> > --- a/tools/perf/util/mem-events.c
> > +++ b/tools/perf/util/mem-events.c
> > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> >  static const char * const snoop_access[] = {
> >  	"N/A",
> >  	"None",
> > -	"Miss",
> >  	"Hit",
> > +	"Miss",
> >  	"HitM",
> >  };
> >  
> > -- 
> > 2.9.3