linux-kernel - Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2017 20:51:13 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Lee Jones <lee.jones@...aro.org>, linux-i2c@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu
 node in example

On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
> 
> While being there, drop the -mfd suffix since isn't correct.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Acked-by: Aaro Koskinen <aaro.koskinen@....fi>
> Acked-by: Tony Lindgren <tony@...mide.com>

Wouldn't it be nice if we fix the driver also so it actually matches the
below compatible? I can't find such a change in linux-next.

> ---
> 
> Changes in v5:
> - Add Rob Herring's Acked-by tag.
> - Add Aaro Koskinen's Acked-by tag.
> - Add Acked-by: Tony Lindgren <tony@...mide.com>'s Acked-by tag.
> 
> Changes in v4:
> - Avoid using MFD in Device Tree (Lee Jones).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> index 8ce9cd2855b5..c143948b2a37 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> @@ -20,8 +20,8 @@ i2c@0 {
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  
> -	retu-mfd: retu@1 {
> -		compatible = "retu-mfd";
> +	retu: retu@1 {
> +		compatible = "nokia,retu";
>  		reg = <0x1>;
>  	};
>  };
> -- 
> 2.9.3
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)