linux-kernel - Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc8fb064-8fda-d42d-036f-522964b72973@osg.samsung.com>
Date:   Wed, 19 Apr 2017 15:13:19 -0400
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-kernel@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Lee Jones <lee.jones@...aro.org>, linux-i2c@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node
 in example

Hello Wolfram,

On 04/19/2017 02:51 PM, Wolfram Sang wrote:
> On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
>> The example contains a device node for a retu device, but
>> its compatible string doesn't have a vendor prefix.
>>
>> While being there, drop the -mfd suffix since isn't correct.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>> Acked-by: Rob Herring <robh@...nel.org>
>> Acked-by: Aaro Koskinen <aaro.koskinen@....fi>
>> Acked-by: Tony Lindgren <tony@...mide.com>
> 
> Wouldn't it be nice if we fix the driver also so it actually matches the
> below compatible? I can't find such a change in linux-next.
> 

[snip]

>>  
>> -	retu-mfd: retu@1 {
>> -		compatible = "retu-mfd";
>> +	retu: retu@1 {
>> +		compatible = "nokia,retu";
>>  		reg = <0x1>;
>>  	};

You mean having a "nokia,retu" entry in a OF table?

That's done by patch 3/8 in this series:

http://www.spinics.net/lists/devicetree/msg173145.html

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America