linux-kernel - Re: [patch V2 08/10] timer: Implement the hierarchical pull model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170419072411.uxd7spyzgs5oszah@hirez.programming.kicks-ass.net>
Date:   Wed, 19 Apr 2017 09:24:11 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-pm@...r.kernel.org, Arjan van de Ven <arjan@...radead.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Rik van Riel <riel@...hat.com>
Subject: Re: [patch V2 08/10] timer: Implement the hierarchical pull model

On Tue, Apr 18, 2017 at 01:11:10PM +0200, Thomas Gleixner wrote:
> @@ -1689,11 +1708,16 @@ static void run_timer_base(int index, bo
>   */
>  static __latent_entropy void run_timer_softirq(struct softirq_action *h)
>  {
> +	struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_LOCAL]);

Does this want to be inside the IS_ENABLED() block below? It seems to me
this could generate an unused variable warning for !NO_HZ_COMMON
compiler.

> +
>  	run_timer_base(BASE_LOCAL, false);
>  
>  	if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) {
>  		run_timer_base(BASE_GLOBAL, false);
>  		run_timer_base(BASE_DEF, true);
> +
> +		if (base->nohz_active)
> +			tmigr_handle_remote();
>  	}
>  }