linux-kernel - Re: [PATCH V4] x86: call smp vmxoff in smp stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <393949858.14449581.1492590121377.JavaMail.zimbra@redhat.com>
Date:   Wed, 19 Apr 2017 04:22:01 -0400 (EDT)
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Xishi Qiu <qiuxishi@...wei.com>, Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        the arch/x86 maintainers <x86@...nel.org>,
        wanpeng li <wanpeng.li@...mail.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        hidehiro kawai ez <hidehiro.kawai.ez@...achi.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Fengtiantian <fengtiantian@...wei.com>,
        Xiexiuqi <xiexiuqi@...wei.com>
Subject: Re: [PATCH V4] x86: call smp vmxoff in smp stop


> > On 18/01/2017 12:32, Xishi Qiu wrote:
> > > From: Tiantian Feng <fengtiantian@...wei.com>
> > > 
> > > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > > signals when VMX is enabled. In kernel mainline this issue existence.
> 
> Yes, but the changelog is atrcious:
> 
>  - title should describe the purpose, not the implementation
> 
>  - CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!
> 
>  - typos
> 
>  - spelling
> 
>  - the last sentence doesn't even parse ...
> 
> Still it's already at V4 and comes with two signoffs and what amounts to a
> maintainer Ack??

Well, the v2-v4 were really just about getting the signoffs right.  At some
point you just get desensitized about the changelog. :(

I'll post v5 with a rewritten commit message.

Paolo