linux-kernel - Re: [PATCH 4.4 27/32] MIPS: Force o32 fp64 support on 32bit MIPS64r6 kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2017 15:13:22 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        James Hogan <james.hogan@...tec.com>,
        Paul Burton <paul.burton@...tec.com>,
        Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org
Subject: Re: [PATCH 4.4 27/32] MIPS: Force o32 fp64 support on 32bit MIPS64r6
 kernels

On Sat, Apr 15, 2017 at 12:45:42AM +0100, Maciej W. Rozycki wrote:
> On Mon, 10 Apr 2017, Greg Kroah-Hartman wrote:
> 
> > Force o32 fp64 support in this case by also selecting
> > MIPS_O32_FP64_SUPPORT from CPU_MIPS64_R6 if 32BIT.
> [...]
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -1412,7 +1412,7 @@ config CPU_MIPS32_R6
> >  	select CPU_SUPPORTS_MSA
> >  	select GENERIC_CSUM
> >  	select HAVE_KVM
> > -	select MIPS_O32_FP64_SUPPORT
> > +	select MIPS_O32_FP64_SUPPORT if 32BIT
> >  	help
> >  	  Choose this option to build a kernel for release 6 or later of the
> >  	  MIPS32 architecture.  New MIPS processors, starting with the Warrior
> 
>  Has the patch been misapplied?  Its description refers to CPU_MIPS64_R6, 
> however the hunk heading in the diff itself indicates CPU_MIPS32_R6.

Ugh, you are right, I think I had to apply this one by hand, and got it
really wrong.  I'll go fix it up now, many thanks for pointing it out.

greg k-h