linux-kernel - Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2017 11:40:37 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     "Reshetova, Elena" <elena.reshetova@...el.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        "Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>
Subject: Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

On Thu, Apr 20, 2017 at 9:40 AM, Reshetova, Elena
<elena.reshetova@...el.com> wrote:
>
>> On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova
>> <elena.reshetova@...el.com> wrote:
>> > Now when new refcount_t type and API are finally merged
>> > (see include/linux/refcount.h), the following
>> > patches convert various refcounters in the ceph filesystem from atomic_t
>> > to refcount_t. By doing this we prevent intentional or accidental
>> > underflows or overflows that can led to use-after-free vulnerabilities.
>> >
>> > The below patches are fully independent and can be cherry-picked separately.
>> > Since we convert all kernel subsystems in the same fashion, resulting
>> > in about 300 patches, we have to group them for sending at least in some
>> > fashion to be manageable. Please excuse the long cc list.
>> >
>> > Not runtime tested, since I am not sure how to do it for ceph.
>> > However changes are pretty trivial in this case.
>> >
>> > Elena Reshetova (2):
>> >   fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
>> >   fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t
>> >
>> >  fs/ceph/caps.c       |  4 ++--
>> >  fs/ceph/mds_client.c | 18 +++++++++---------
>> >  fs/ceph/mds_client.h |  5 +++--
>> >  fs/ceph/snap.c       |  2 +-
>> >  fs/ceph/super.h      |  5 +++--
>> >  5 files changed, 18 insertions(+), 16 deletions(-)
>>
>> I'll pull these into testing.
>
> Just a check: how did testing went on this?
> If everything is good, can you merge the changes?

Yep, I'll merge these into 4.12.

Thanks,

                Ilya