linux-kernel - Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <376c5933-9321-5399-74c7-6fd4943fab3d@synopsys.com>
Date:   Fri, 21 Apr 2017 11:34:00 +0100
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>
CC:     Jose Abreu <Jose.Abreu@...opsys.com>,
        Lubomir Rintel <lkundrak@...sk>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm
 as a module

Hi,


On 20-04-2017 21:24, Takashi Iwai wrote:
> So, I think Lubomir's change is right.  But the patch subject and
> description should be rephrased.
>
> One thing I don't like is the rename of the file.  But in this
> particular case, it's unavoidable unless we rename the module name.
>

Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
called "dwc") and let the module still be called "designware-i2s"?

> BTW, we should drop the superfluous EXPORT_SYMBOL*(), too.
>
>
>

Lubomir, could you please remove the EXPORT_SYMBOL, change the
commit message and resend?

Best regards,
Jose Miguel Abreu