linux-kernel - Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hshl2kpst.wl-tiwai@suse.de>
Date:   Fri, 21 Apr 2017 12:39:30 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Jose Abreu <Jose.Abreu@...opsys.com>
Cc:     Mark Brown <broonie@...nel.org>, Lubomir Rintel <lkundrak@...sk>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module

On Fri, 21 Apr 2017 12:34:00 +0200,
Jose Abreu wrote:
> 
> Hi,
> 
> 
> On 20-04-2017 21:24, Takashi Iwai wrote:
> > So, I think Lubomir's change is right.  But the patch subject and
> > description should be rephrased.
> >
> > One thing I don't like is the rename of the file.  But in this
> > particular case, it's unavoidable unless we rename the module name.
> >
> 
> Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
> called "dwc") and let the module still be called "designware-i2s"?

Lubomir's patch keeps the module name intact.  My point is that rename
of a file isn't nice to look at the git commit history, so it's better
to be avoided as much as possible.  But in this case, it looks
unavoidable.


Takashi