linux-kernel - Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170421104915.x7gxt5yqcuewa7rv@sirena.org.uk>
Date:   Fri, 21 Apr 2017 11:49:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jose Abreu <Jose.Abreu@...opsys.com>,
        Lubomir Rintel <lkundrak@...sk>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm
 as a module

On Fri, Apr 21, 2017 at 12:39:30PM +0200, Takashi Iwai wrote:
> Jose Abreu wrote:

> > Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
> > called "dwc") and let the module still be called "designware-i2s"?

> Lubomir's patch keeps the module name intact.  My point is that rename
> of a file isn't nice to look at the git commit history, so it's better
> to be avoided as much as possible.  But in this case, it looks
> unavoidable.

Right.  Renaming the source file is the lesser evil, it's possible
people might have the module name in their configuration for their
systems somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)