linux-kernel - [PATCH] platform/x86: INT33FE: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170421210331.876697-1-arnd@arndb.de>
Date:   Fri, 21 Apr 2017 23:03:13 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Hans de Goede <hdegoede@...hat.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] platform/x86: INT33FE: add I2C dependency

When I2C is disabled, we get a link error:

drivers/platform/built-in.o: In function `cht_int33fe_remove':
intel_cht_int33fe.c:(.text+0x8ba): undefined reference to `i2c_unregister_device'
drivers/platform/built-in.o: In function `cht_int33fe_probe':
intel_cht_int33fe.c:(.text+0x9ec): undefined reference to `i2c_acpi_new_device'
intel_cht_int33fe.c:(.text+0xa7a): undefined reference to `i2c_unregister_device'

This adds a Kconfig dependency to ensure I2C is available to this
driver.

Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 76ced87efde5..4c7db1fbac26 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -782,7 +782,7 @@ config ACPI_CMPC
 
 config INTEL_CHT_INT33FE
 	tristate "Intel Cherry Trail ACPI INT33FE Driver"
-	depends on X86 && ACPI
+	depends on X86 && ACPI && I2C
 	---help---
 	  This driver add support for the INT33FE ACPI device found on
 	  some Intel Cherry Trail devices.
-- 
2.9.0