linux-kernel - Re: [PATCH] platform/x86: INT33FE: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170421214219.GB31650@fury>
Date:   Fri, 21 Apr 2017 14:42:19 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: INT33FE: add I2C dependency

On Fri, Apr 21, 2017 at 11:03:13PM +0200, Arnd Bergmann wrote:
> When I2C is disabled, we get a link error:
> 
> drivers/platform/built-in.o: In function `cht_int33fe_remove':
> intel_cht_int33fe.c:(.text+0x8ba): undefined reference to `i2c_unregister_device'
> drivers/platform/built-in.o: In function `cht_int33fe_probe':
> intel_cht_int33fe.c:(.text+0x9ec): undefined reference to `i2c_acpi_new_device'
> intel_cht_int33fe.c:(.text+0xa7a): undefined reference to `i2c_unregister_device'
> 
> This adds a Kconfig dependency to ensure I2C is available to this
> driver.
> 
> Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks Arnd, Tobias submitted a fix a short time ago, it'll be in next tomorrow.
Thanks!

-- 
Darren Hart
VMware Open Source Technology Center