lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Apr 2017 12:41:53 +0100 From: Lee Jones <lee.jones@...aro.org> To: Tony Lindgren <tony@...mide.com> Cc: Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, Felipe Balbi <felipe.balbi@...ux.intel.com>, Keshava Munegowda <keshava_mgowda@...com>, Marcel Partap <mpartap@....net>, Michael Scott <michael.scott@...aro.org>, Roger Quadros <rogerq@...com>, Sebastian Reichel <sre@...nel.org> Subject: Re: [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE On Sat, 15 Apr 2017, Tony Lindgren wrote: > The idle mode needs to be only disabled for UTMIAUTOIDLE while > ULPIAUTOIDLE can be enabled. > > This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll > in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4 > and the modem still stays responsive. > > Cc: Felipe Balbi <felipe.balbi@...ux.intel.com> > Cc: Keshava Munegowda <keshava_mgowda@...com> > Cc: Marcel Partap <mpartap@....net> > Cc: Michael Scott <michael.scott@...aro.org> > Cc: Roger Quadros <rogerq@...com> > Cc: Sebastian Reichel <sre@...nel.org> > Signed-off-by: Tony Lindgren <tony@...mide.com> > --- > drivers/mfd/omap-usb-tll.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata) > } else if (pdata->port_mode[i] == > OMAP_EHCI_PORT_MODE_TLL) { > /* > - * Disable AutoIdle, BitStuffing > - * and use SDR Mode > + * Disable UTMI AutoIdle, BitStuffing > + * and use SDR Mode. Enable ULPI AutoIdle. > */ > reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE > | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); > reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF; > + reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE; > } else if (pdata->port_mode[i] == > OMAP_EHCI_PORT_MODE_HSIC) { > /* -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists