linux-kernel - Re: [PATCH 1/2] perf tools: Guard _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170424130547.GS4021@tassilo.jf.intel.com>
Date:   Mon, 24 Apr 2017 06:05:47 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Tony Jones <tonyj@...e.de>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c

On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote:
> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent 
> possible redefinition error.

Who defines it? 

If it's always defined somewhere else it can be just removed.

-Andi

> 
> Signed-off-by: Tony Jones <tonyj@...e.de>
> ---
>  tools/perf/pmu-events/jevents.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index baa073f38334..b6300e875b87 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -1,5 +1,7 @@
>  #define  _XOPEN_SOURCE 500	/* needed for nftw() */
> +#ifndef  _GNU_SOURCE
>  #define  _GNU_SOURCE		/* needed for asprintf() */
> +#endif
>  
>  /* Parse event JSON files */
>  
> -- 
> 2.11.0
>