linux-kernel - Re: [PATCH 1/2] perf tools: Guard _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e91ca3e-248a-0882-094d-60c37446483b@suse.de>
Date:   Mon, 24 Apr 2017 08:45:48 -0700
From:   Tony Jones <tonyj@...e.de>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c

On 04/24/2017 06:05 AM, Andi Kleen wrote:
> On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote:
>> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent 
>> possible redefinition error.
> 
> Who defines it? 
> 
> If it's always defined somewhere else it can be just removed.
> 
> -Andi

sometimes it's defaulted on (I believe) by the toolchain.    it fails on our SLE12-SP3 toolchain.
I assumed the existing guard in pt-decoder/intel-pt-decoder.c (only other use) was for a reason.

tony