linux-kernel - Re: [PATCH] gpio: dwapb: use dwapb_read instead of readl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbZ5JuQLFGmejnruzyGR-6h27Cwa0EObL=V6EO=V9nRqw@mail.gmail.com>
Date:   Mon, 24 Apr 2017 15:09:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jisheng Zhang <jszhang@...vell.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: dwapb: use dwapb_read instead of readl_relaxed

On Thu, Apr 13, 2017 at 11:46 AM, Jisheng Zhang <jszhang@...vell.com> wrote:

> Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
> dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
> sure the reason, maybe for performance reason? But if we do care
> the performance, we could use the relaxed io in dwapb_read and
> dwapb_write.
>
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

Patch applied.

Yours,
Linus Walleij