linux-kernel - Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170424180222.GL14088@mtr-leonro.local>
Date:   Mon, 24 Apr 2017 21:02:22 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Doug Ledford <dledford@...hat.com>
Cc:     Dennis Dalessandro <dennis.dalessandro@...el.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Devesh Sharma <devesh.sharma@...gotech.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Selvin Xavier <selvin.xavier@...gotech.com>,
        Yuval Shaia <yuval.shaia@...cle.com>,
        linux-rdma@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten
 functions

On Mon, Apr 24, 2017 at 12:38:58PM -0400, Doug Ledford wrote:
> On Mon, 2017-04-24 at 08:54 -0400, Dennis Dalessandro wrote:
> > On 04/23/2017 03:33 AM, Leon Romanovsky wrote:
> > >
> > > On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote:
> > > >
> > > > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > > > Date: Sat, 22 Apr 2017 13:26:49 +0200
> > > >
> > > > Replace the specification of data types by pointer dereferences
> > > > as the parameter for the operator "sizeof" to make the
> > > > corresponding size
> > > > determinations a bit safer according to the Linux coding style
> > > > convention.
> > > >
> > > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > > > ---
> > > >
> > > > v2:
> > > > Changes were rebased on source files from Linux next-20170421.
> > > > These were recombined as requested by Doug Ledford.
> > >
> > > Hi Doug,
> > >
> > > I recommend you to be extra cautious with this blind automatic
> > > conversions. It requires inspection that every size before and
> > > after
> > > match each other.
> > >
> > > I already asked it and would be like to repeat it. Please DON'T
> > > take any
> > > patches from Markus, which are related to mlx4/mlx5/rxe without our
> > > explicit
> > > review of them.
> >
> > I agree with Leon here, and these sort of find/replace automagic 
> > clean-up patches make me nervous sometimes.
>
> OK, the easiest way to make sure that only the things you want from his
> patches get through is to have you pull them into a branch and submit
> them yourself.  I'll only take the ones you submit to me, that way
> there is no confusion about whether or not you have checked them and
> approved them.

Fine to me.

Thanks

>
> > Markus, what have you done to ensure your patches don't break
> > anything?
> >
> > -Denny
> >
> --
> Doug Ledford <dledford@...hat.com>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)