linux-kernel - Re: [kbuild-all] [PATCH RT] usb: Use _nort in usb_hcd_pci_remove

Open Source and information security mailing list archives

Date:   Tue, 25 Apr 2017 21:06:21 +0800
From:   Philip Li <philip.li@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     kbuild test robot <lkp@...el.com>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Nate Dailey <nate.dailey@...atus.com>, bigeasy@...utronix.de,
        tglx@...utronix.de, kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: Re: [kbuild-all] [PATCH RT] usb: Use _nort in usb_hcd_pci_remove

On Tue, Apr 25, 2017 at 08:01:54AM -0400, Steven Rostedt wrote:
> On Tue, 25 Apr 2017 13:26:41 +0800
> kbuild test robot <lkp@...el.com> wrote:
> 
> > Hi Nate,
> > 
> > [auto build test ERROR on usb/usb-testing]
> > [also build test ERROR on v4.11-rc8 next-20170424]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> Hi Fengguang,
> 
> You may want to have your bot look at the subject. If there's an "RT"
> in the [PATCH ...] portion, then you need to apply the PREEMPT_RT
> patch, or use one of the RT git trees for it.
> 
> This patch is applied to the RT trees.
thanks Steve for the feedback, we will update the logic to handle this situation.

> 
> Thanks!
> 
> -- Steve
> 
> > 
> > url:    https://github.com/0day-ci/linux/commits/Nate-Dailey/usb-Use-_nort-in-usb_hcd_pci_remove/20170424-214548
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > config: x86_64-rhel (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/usb//core/hcd-pci.c: In function 'usb_hcd_pci_remove':
> > >> drivers/usb//core/hcd-pci.c:344:2: error: implicit declaration of function 'local_irq_disable_nort' [-Werror=implicit-function-declaration]  
> >      local_irq_disable_nort();
> >      ^~~~~~~~~~~~~~~~~~~~~~
> > >> drivers/usb//core/hcd-pci.c:346:2: error: implicit declaration of function 'local_irq_enable_nort' [-Werror=implicit-function-declaration]  
> >      local_irq_enable_nort();
> >      ^~~~~~~~~~~~~~~~~~~~~
> >    cc1: some warnings being treated as errors
> > 
> > vim +/local_irq_disable_nort +344 drivers/usb//core/hcd-pci.c
> > 
> >    338			pm_runtime_get_noresume(&dev->dev);
> >    339	
> >    340		/* Fake an interrupt request in order to give the driver a chance
> >    341		 * to test whether the controller hardware has been removed (e.g.,
> >    342		 * cardbus physical eject).
> >    343		 */
> >  > 344		local_irq_disable_nort();  
> >    345		usb_hcd_irq(0, hcd);
> >  > 346		local_irq_enable_nort();  
> >    347	
> >    348		/* Note: dev_set_drvdata must be called while holding the rwsem */
> >    349		if (dev->class == CL_EHCI) {
> > 
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@...ts.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives