linux-kernel - Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2017 07:36:40 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Michael Ellerman <mpe@...erman.id.au>, shuah@...nel.org,
        bamvor.zhangjian@...aro.org, benh@...nel.crashing.org,
        paulus@...ba.org, dvhart@...radead.org
Cc:     viro@...iv.linux.org.uk, emilio.lopez@...labora.co.uk,
        mingo@...nel.org, luto@...nel.org, dave.hansen@...ux.intel.com,
        dsafonov@...tuozzo.com, rkrcmar@...hat.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow
 Makefiles to override clean

On 04/21/2017 11:38 PM, Michael Ellerman wrote:
> Shuah Khan <shuahkh@....samsung.com> writes:
> 
>> Define CLEAN macro to allow Makefiles to override common clean target
>> in lib.mk. This will help fix the following failures:
>>
>> warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> 
> Should probably have:
> 
> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")

Amended the change log to add the above.

> 
> 
> In hindsight I'm not sure moving the clean target into lib.mk was
> the best idea, but anyway it's a bit late to change our mind on that.

Yeah. Moving clean target to lib.mk ended up to be problematic. However,
there are some advantages as well. It will simplify some Makefiles. One
thing that was missed was that not finding the Makefiles that require
overrides. Anyway live and learn.

> 
> This patch is a good solution to fix the warnings.
> 
> Acked-by: Michael Ellerman <mpe@...erman.id.au>
> 

Thanks. I plan to apply the patch with the amended changelog and your
Ack. Please let me know if you want to see v2 with the change sent out.

thanks,
-- Shuah