linux-kernel - Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f95aeee4-a5cf-6b66-c451-eac059cb0ca6@osg.samsung.com>
Date:   Tue, 25 Apr 2017 09:02:02 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Michael Ellerman <mpe@...erman.id.au>, shuah@...nel.org,
        bamvor.zhangjian@...aro.org, benh@...nel.crashing.org,
        paulus@...ba.org, dvhart@...radead.org
Cc:     viro@...iv.linux.org.uk, emilio.lopez@...labora.co.uk,
        mingo@...nel.org, luto@...nel.org, dave.hansen@...ux.intel.com,
        dsafonov@...tuozzo.com, rkrcmar@...hat.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix
 warnings

On 04/21/2017 11:40 PM, Michael Ellerman wrote:
> Shuah Khan <shuahkh@....samsung.com> writes:
> 
>> Add override for lib.mk clean to fix the following warnings from clean
>> target run.
>>
>> Makefile:11: warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  tools/testing/selftests/gpio/Makefile | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
>> index 205e4d1..4f6d9e0 100644
>> --- a/tools/testing/selftests/gpio/Makefile
>> +++ b/tools/testing/selftests/gpio/Makefile
>> @@ -7,8 +7,9 @@ include ../lib.mk
>>  
>>  all: $(BINARIES)
>>  
>> -clean:
>> +override define CLEAN
>>  	$(RM) $(BINARIES)
>> +endef
> 
> This could be achieved more simply with:
> 
> EXTRA_CLEAN := $(BINARIES)
> 

gpio clean requires special handling. I have one more patch
I sent out that handles that. So I am going to leave this
patch the way with override.

thanks,
-- Shuah