linux-kernel - Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170427115554.GA22360@kroah.com>
Date:   Thu, 27 Apr 2017 13:55:54 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     agruenba@...hat.com, keescook@...omium.org,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
        viro@...iv.linux.org.uk, oleg@...hat.com, paul@...l-moore.com,
        ebiederm@...ssion.com, avagin@...nvz.org,
        linux-fsdevel@...r.kernel.org, mtk.manpages@...il.com,
        akpm@...ux-foundation.org, luto@...capital.net,
        gorcunov@...nvz.org, mingo@...nel.org, serge@...lyn.com
Subject: Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of
 ns_last_pid's on ns hierarhy

On Thu, Apr 27, 2017 at 01:57:16PM +0300, Kirill Tkhai wrote:
> --- a/include/uapi/linux/nsfs.h
> +++ b/include/uapi/linux/nsfs.h
> @@ -14,5 +14,12 @@
>  #define NS_GET_NSTYPE		_IO(NSIO, 0x3)
>  /* Get owner UID (in the caller's user namespace) for a user namespace */
>  #define NS_GET_OWNER_UID	_IO(NSIO, 0x4)
> +/* Set a vector of ns_last_pid for a pid namespace stack */
> +#define NS_SET_LAST_PID_VEC	_IO(NSIO, 0x5)
> +
> +struct ns_ioc_pid_vec {
> +	unsigned int nr;

Please make this an explicit type, variables that cross the user/kernel
boundry should be using __u32 and friends, not vague things like "int".

thanks,

greg k-h