linux-kernel - Re: [PATCH v2 4/9] KVM: mark requests that do not need a wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170427140016.68e4cefe.cornelia.huck@de.ibm.com>
Date:   Thu, 27 Apr 2017 14:00:16 +0200
From:   Cornelia Huck <cornelia.huck@...ibm.com>
To:     Radim Krčmář <rkrcmar@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Christoffer Dall <cdall@...aro.org>,
        Andrew Jones <drjones@...hat.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        James Hogan <james.hogan@...tec.com>,
        Paul Mackerras <paulus@...abs.org>
Subject: Re: [PATCH v2 4/9] KVM: mark requests that do not need a wakeup

On Wed, 26 Apr 2017 22:32:22 +0200
Radim Krčmář <rkrcmar@...hat.com> wrote:

> Some operations must ensure that the guest is not running with stale
> data, but if the guest is halted, then the update can wait until another
> event happens.  kvm_make_all_requests() currently doesn't wake up, so we
> can mark all requests used with it.
> 
> First 8 bits were arbitrarily reserved for request numbers.
> 
> Most uses of requests have the request type as a constant, so a compiler
> will optimize the '&'.
> 
> An alternative would be to have an inline function that would return
> whether the request needs a wake-up or not, but I like this one better
> even though it might produce worse assembly.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> ---
>  v2: use GENMASK [Marc]
> ---
>  arch/arm/include/asm/kvm_host.h   |  2 +-
>  arch/arm64/include/asm/kvm_host.h |  2 +-
>  arch/x86/include/asm/kvm_host.h   |  6 +++---
>  include/linux/kvm_host.h          | 12 +++++++-----
>  4 files changed, 12 insertions(+), 10 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>