linux-kernel - Re: [PATCH v3 09/29] x86: assembly, use DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170427124310.GC23352@amd>
Date:   Thu, 27 Apr 2017 14:43:10 +0200
From:   Pavel Machek <pavel@....cz>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data

On Thu 2017-04-27 14:30:05, Jiri Slaby wrote:
> Hi,
> 
> On 04/27/2017, 01:53 PM, Pavel Machek wrote:
> >> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel)
> >>  
> >>  .data
> >>  ALIGN
> >> -ENTRY(saved_magic)	.long	0
> >> -ENTRY(saved_eip)	.long	0
> >> +SYM_DATA_SIMPLE(saved_magic, .long 0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0)
> >>  
> >>  # saved registers
> >> -saved_idt:	.long	0,0
> >> -saved_ldt:	.long	0
> >> -saved_tss:	.long	0
> >> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0)
> > 
> > Do we really need to mark local data like that? It complicates the
> > source code a bit...
> 
> Not really -- if the preferred way is not to annotate local symbols, I
> can indeed remove that.

I'd prefer that ;-).
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)