linux-kernel - RE: [PATCH] iov_iter: don't revert if csum error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE1464@AcuExch.aculab.com>
Date:   Fri, 28 Apr 2017 13:51:43 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Sabrina Dubroca' <sd@...asysnail.net>,
        Ding Tianhong <dingtianhong@...wei.com>
CC:     David Miller <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        LinuxArm <linuxarm@...wei.com>
Subject: RE: [PATCH] iov_iter: don't revert if csum error

From: Sabrina Dubroca
> Sent: 28 April 2017 14:17
...
> >  		if (__skb_checksum_complete(skb))
> > -			goto csum_error;
> > +			goto fault;
> 
> With this patch, skb_copy_and_csum_datagram_msg() will return -EFAULT
> for an incorrect checksum, that doesn't seem right.

Especially since (IIRC) -EFAULT generates SIGSEGV.

	David