linux-kernel - Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428221435.GA32336@fury>
Date:   Fri, 28 Apr 2017 15:14:35 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy@...radead.org>,
        Jean Delvare <jdelvare@...e.de>
Subject: Re: [PATCH] platform/x86: Make SILEAD_DMI depend on
 TOUCHSCREEN_SILEAD

On Fri, Apr 28, 2017 at 02:09:00PM -0700, Dmitry Torokhov wrote:
> On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> > SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> > driver. Make this explicitly clear in the Kconfig depends.
> > 
> > Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Cc: Andy Shevchenko <andy@...radead.org>
> > Cc: Jean Delvare <jdelvare@...e.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > ---
> >  drivers/platform/x86/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 9e5b2c2..5690664 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
> >  
> >  config SILEAD_DMI
> >  	bool "Tablets with Silead touchscreens"
> > -	depends on ACPI && DMI && I2C=y && INPUT
> > +	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
> 
> Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
> INPUT dependency.
> 

Done, thanks.

> Otherwise
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> -- 
> Dmitry
> 

-- 
Darren Hart
VMware Open Source Technology Center