linux-kernel - [PATCH RESEND] fs: compat: Remove warning from COMPATIBLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170428221512.47856-1-mka@chromium.org>
Date:   Fri, 28 Apr 2017 15:15:12 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        Mark Charlebois <charlebm@...il.com>,
        Behan Webster <behanw@...verseincode.com>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Matthias Kaehlcke <mka@...omium.org>
Subject: [PATCH RESEND] fs: compat: Remove warning from COMPATIBLE_IOCTL

From: Mark Charlebois <charlebm@...il.com>

cmd in COMPATIBLE_IOCTL is always a u32, so cast it so there isn't a
warning about an overflow in XFORM.

From: Mark Charlebois <charlebm@...il.com>
Signed-off-by: Mark Charlebois <charlebm@...il.com>
Signed-off-by: Behan Webster <behanw@...verseincode.com>
Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
Acked-by: Arnd Bergmann <arnd@...db.de>
---
 fs/compat_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 11d087b2b28e..6116d5275a3e 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -833,7 +833,7 @@ static int compat_ioctl_preallocate(struct file *file,
  */
 #define XFORM(i) (((i) ^ ((i) << 27) ^ ((i) << 17)) & 0xffffffff)
 
-#define COMPATIBLE_IOCTL(cmd) XFORM(cmd),
+#define COMPATIBLE_IOCTL(cmd) XFORM((u32)cmd),
 /* ioctl should not be warned about even if it's not implemented.
    Valid reasons to use this:
    - It is implemented with ->compat_ioctl on some device, but programs
-- 
2.13.0.rc0.306.g87b477812d-goog