linux-kernel - [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2017 11:23:34 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in
 pinconf_dbg_config_print()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 1 May 2017 22:52:29 +0200

Some data were put into a sequence by five separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/pinctrl/pinconf.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a14ae8601b39..d37f98aafb4b 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -441,12 +441,15 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d)
 	}
 
 	if (!found) {
-		seq_printf(s, "No config found for dev/state/pin, expected:\n");
-		seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
-		seq_printf(s, "Searched state:%s\n", dbg->state_name);
-		seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
-		seq_printf(s, "Use: modify config_pin <devname> "\
-				"<state> <pinname> <value>\n");
+		seq_printf(s,
+			   "No config found for dev/state/pin, expected:\n"
+			   "Searched dev:%s\n"
+			   "Searched state:%s\n"
+			   "Searched pin:%s\n"
+			   "Use: modify config_pin <devname> <state> <pinname> <value>\n",
+			   dbg->dev_name,
+			   dbg->state_name,
+			   dbg->pin_name);
 		goto exit;
 	}
 
-- 
2.12.2